Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add nvidia-mdev VA #412

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sbauza
Copy link

@sbauza sbauza commented Oct 2, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from abays and raukadah October 2, 2024 13:42
Copy link

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sbauza
Once this PR has been reviewed and has the lgtm label, please assign raukadah for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 2, 2024

Hi @sbauza. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbauza sbauza force-pushed the va-nvidia-mdev branch 2 times, most recently from 2dd3408 to 86e8f00 Compare October 8, 2024 09:21
@gibizer
Copy link
Contributor

gibizer commented Oct 8, 2024

/ok-to-test

timesync_ntp_servers:
- hostname: pool.ntp.org
# CPU pinning settings
edpm_kernel_args: "default_hugepagesz=1GB hugepagesz=1G hugepages=16 intel_iommu=on iommu=pt isolcpus=4-23,28-47"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: isolcpus shoudl not be used on non realtime hosts
isolcpus=4-23,28-47

we can fix this later

hostName: edpm-compute-1
services:
- neutron-ovn
- nova-custom-sriov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: in a followup we shoudl avoid using the nova-custom-sriov and use the standard nova datapalne service.

we do not need to create a custom one but that simplicaftion can be done in a follow up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list of services however is incomplete

we need to include all of the service that should be deployed ill see if i can provide a suggestion for that shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants