Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable extra mount in uni02beta #349

Conversation

sdatko
Copy link
Contributor

@sdatko sdatko commented Jul 31, 2024

It fails again due to some NetApp issues (?).
In this change, we keep the configuration for it,
but just remove from kustomization the creation
of that extra mount, so it can be used as a workaround until the problem is resolved.

Copy link

openshift-ci bot commented Jul 31, 2024

Hi @sdatko. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tosky
Copy link
Contributor

tosky commented Jul 31, 2024

/lgtm

@arxcruz
Copy link
Contributor

arxcruz commented Jul 31, 2024

/lgtm
/approve
/ok-to-test

@sdatko sdatko marked this pull request as ready for review July 31, 2024 13:37
@openshift-ci openshift-ci bot requested review from fultonj and raukadah July 31, 2024 13:37
It fails again due to some NetApp issues (?).
In this change, we keep the configuration for it,
but just remove from kustomization the creation
of that extra mount, so it can be used as a workaround
until the problem is resolved.
@fultonj
Copy link
Contributor

fultonj commented Jul 31, 2024

I'd prefer a removal to a comment out. But can't you just not override data.glance.extraMounts in the job definition if you don't want kustomize to affect it? I assume this works around a problem, but isn't there a better way to do the workaround?

@sdatko sdatko marked this pull request as draft July 31, 2024 14:08
@sdatko
Copy link
Contributor Author

sdatko commented Jul 31, 2024

Hmm... let me see if it will not complain if I override it to empty list in the job...

@sdatko
Copy link
Contributor Author

sdatko commented Jul 31, 2024

Settomg data.glance.extraMounts to [] resulted in:

stderr: 'error: accumulating components: accumulateDirectory: "recursed accumulation of path ''/home/zuul/src/github.com/openstack-k8s-operators/architecture/dt/uni02beta'': fieldPath `data.glance.extraMounts` is missing for replacement source ConfigMap.[noVer].[noGrp]/service-values.[noNs]"'`

@sdatko sdatko marked this pull request as ready for review July 31, 2024 20:46
@openshift-ci openshift-ci bot requested a review from abays July 31, 2024 20:46
@sdatko
Copy link
Contributor Author

sdatko commented Jul 31, 2024

I know it is not super nice, but at the same time we are more interested to see tests results from other services in that scenario, rather that deployment failure again...

@fultonj
Copy link
Contributor

fultonj commented Jul 31, 2024

  • merging this to unblock an important job with the understanding that it will be reverted soon

Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arxcruz, fultonj, sdatko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/af4c60544c3f4cd7abbd24e3380b3469

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni02beta SUCCESS in 3m 55s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit eedc98a into openstack-k8s-operators:main Jul 31, 2024
7 checks passed
@fultonj fultonj added needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges and removed needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges labels Aug 6, 2024
@fultonj
Copy link
Contributor

fultonj commented Aug 6, 2024

The proposal to revert has arrived #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants