-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable extra mount in uni02beta #349
Disable extra mount in uni02beta #349
Conversation
Hi @sdatko. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
/lgtm |
It fails again due to some NetApp issues (?). In this change, we keep the configuration for it, but just remove from kustomization the creation of that extra mount, so it can be used as a workaround until the problem is resolved.
34b8011
to
43ba5f8
Compare
I'd prefer a removal to a comment out. But can't you just not override |
Hmm... let me see if it will not complain if I override it to empty list in the job... |
Settomg
|
I know it is not super nice, but at the same time we are more interested to see tests results from other services in that scenario, rather that deployment failure again... |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arxcruz, fultonj, sdatko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
eedc98a
into
openstack-k8s-operators:main
The proposal to revert has arrived #356 |
It fails again due to some NetApp issues (?).
In this change, we keep the configuration for it,
but just remove from kustomization the creation
of that extra mount, so it can be used as a workaround until the problem is resolved.