Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for getting a files stats #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnuoy
Copy link
Contributor

@gnuoy gnuoy commented Jun 5, 2019

No description provided.

Copy link
Collaborator

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think it needs a change due to how Stdout/stdout handling changed in the last year.

unit = get_unit_from_name(unit_name, model=model)
output = await unit.run(
'stat --format "{}" {}'.format(stat_format, remote_file))
return output.data.get('results')['Stdout'].strip()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is still needed, then I think this needs to go through _normalise_action_results?

@ajkavanagh ajkavanagh added the stale Nothing happening with the PR for a long time; pending delete. label Jun 29, 2022
coreycb pushed a commit to coreycb/zaza that referenced this pull request Oct 17, 2023
…tions

Fix glance simplestreams sync test races
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Nothing happening with the PR for a long time; pending delete.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants