-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watcher antelope #1175
Open
wolsen
wants to merge
9
commits into
openstack-charmers:stable/antelope
Choose a base branch
from
wolsen:watcher-antelope
base: stable/antelope
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Watcher antelope #1175
wolsen
wants to merge
9
commits into
openstack-charmers:stable/antelope
from
wolsen:watcher-antelope
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add get_watcher_session_client() helper function to build a watcherclient.v1.Client instance authenticated with a keystone session that uses admin credentials by default. (cherry picked from commit fd82476)
This allows callers to pass None and let get_nova_session_client() to use a sane default API, specifically this allows intermediate users (e.g. launch_guest() ) to proxy values passed by the caller. (cherry picked from commit 3283ed4)
This change exposes two new parameters in the launch_instance() function: - nova_api_version: Set the microversion the novaclient should use. - host: Request to launch the instance on a specific hypervisor host. (cherry picked from commit be6ba2a)
The stop_status parameter allows callers to ask stop retrying based on a list of statuses that are known to be final (and error) states, this saves time failing earlier. Usage example for fail early when an instance reaches to ERROR status: openstack_utils.resource_reaches_status(self.nova_client.servers, instance_uuid, resource_attribute='state', expected_status='ACTIVE', stop_status='ERROR') (cherry picked from commit 11c3f80)
This simplifies when developing new tests and the programmer is not too familiar with the different attributes an object has. (cherry picked from commit 55b3145)
This test launches 1 instance per hypervisor, and then launches a new audit to optimize the use of hypervisors and consolidate the instances in a single hypervisor, but also disabling the nova-compute service to avoid new instances get allocated. (cherry picked from commit 6787c84)
(cherry picked from commit 1d42b64)
(cherry picked from commit 4491642)
(cherry picked from commit b087c0c)
This is being tested in https://review.opendev.org/c/openstack/charm-watcher/+/903604 |
openstack-mirroring
pushed a commit
to openstack/charm-watcher
that referenced
this pull request
Mar 28, 2024
Backport the watcher support to 2023.1. This involves the following: * Update .gitreview file * Update charmcraft.yaml with proper bases * Update osci jobs in osci.yaml * Update src/metadata.yaml to add focal support, fix description * Update src/test-requirements.yaml for 2023.1 zaza branches * Update src/wheelhouse.txt for stable/antelope branches * Update test bundles to use 2023.1 * Add override to specify the common cpu-model Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1175 Change-Id: I81963bae26f6e8f728936da93c364f1c2c7f4a86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport watcher tests to the antelope branch. These are backported from commits in PR #1101