Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dalmatian and Epoxy suppoort #140

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

javacruft
Copy link
Contributor

Add bundles and test configuration for testing Dalmatian and Epoxy on Noble.

Add bundles and test configuration for testing Dalmatian and Epoxy
on Noble.
Copy link
Member

@freyes freyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI got broken when the constraints.txt file was dropped, can you apply this change to tox.ini ?.

diff --git a/tox.ini b/tox.ini
index 37a7cab..7a017d6 100644
--- a/tox.ini
+++ b/tox.ini
@@ -6,6 +6,7 @@ minversion = 3.2.0
 [testenv]
 setenv = VIRTUAL_ENV={envdir}
          PYTHONHASHSEED=0
+         TEST_JUJU3=1
 allowlist_externals =
   juju
   bash
@@ -16,7 +17,6 @@ passenv =
   OS_*
   TEST_*
 deps =
-  -c{env:TEST_CONSTRAINTS_FILE:{toxinidir}/constraints.txt}
   -r{toxinidir}/test-requirements.txt
 install_command =
   pip install {opts} {packages}

The rest looks good to me.

Copy link
Member

@freyes freyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks James.

@freyes freyes merged commit 9176766 into openstack-charmers:master Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants