Add client sniperline and server stationary gun options #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support + UI for the
sv_stationaryguns
andui_sniperline
cvars.The
ui_sniperline
andsv_sniperline
relationship is not obvious for users so I changed their descriptions to try and make it easier to understand. Unfortunately adding theui_sniperline
setting resulted in a small awkward scrollbar on my screen, but I'm not sure what to do about it, and we need to have UI for this cvar somewhere.The
sv_stationaryguns
cvar controls whether stationary guns are allowed to be spawned in maps and shot by players. IMO for a singleplayer experience, having stationary guns enabled by default makes sense.I also ran into issues with the launcher not starting the server properly. This happened because the node.js stream interface chunks
'data'
events, and we were searching for the[NET] ...
string only within one chunk. So on the off chance the string spanned two chunks, we would miss it. Consider this a stop-gap measure while proper IPC is implemented.While this PR is not very ambitious, I'm not familiar with the technologies used in the launcher so please give this a careful review.