Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STONEBLD-2371 Tests for multi platform controller #51236

Closed
wants to merge 1 commit into from
Closed

STONEBLD-2371 Tests for multi platform controller #51236

wants to merge 1 commit into from

Conversation

stuartwdouglas
Copy link
Contributor

No description provided.

@stuartwdouglas stuartwdouglas mentioned this pull request Apr 23, 2024
Open
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

Hi @stuartwdouglas. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@psturc
Copy link
Member

psturc commented Apr 30, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2024
@psturc
Copy link
Member

psturc commented Apr 30, 2024

@stuartwdouglas
apart from the error regarding the owners file which needs to be fixed there are prow config files missing for this repo - see jvm-build-service prow config for reference

psturc
psturc reviewed Apr 30, 2024
View reviewed changes
ci-operator/step-registry/devfile/konflux-nightly/devfile-konflux-nightly-ref.yaml Outdated
@@ -16,6 +16,8 @@ ref:
name: "release:latest"
- env: CI_JBS_REQPROCESSOR_IMAGE
name: "release:latest"
- env: OTP_SERVER_IMAGE
name: "release:latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably no need to add it here, because no job config currently uses this step plus devfiles will be deprecated

psturc
psturc reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartwdouglas wondering, would it make sense to temporarily update this script in this PR so it points to your e2e-tests PR and run rehearsal job to validate it works as expected?

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 1, 2024
@psturc
Copy link
Member

psturc commented May 2, 2024

/pj-rehearse pull-ci-redhat-appstudio-multi-platform-controller-main-multi-platform-controller-e2e

@openshift-ci-robot
Copy link
Contributor

@psturc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stuartwdouglas
Copy link
Contributor Author

@psturc any idea what those failures mean?

@psturc
Copy link
Member

psturc commented May 13, 2024

/pj-rehearse pull-ci-redhat-appstudio-multi-platform-controller-main-multi-platform-controller-e2e

@openshift-ci-robot
Copy link
Contributor

@psturc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@psturc
Copy link
Member

psturc commented May 13, 2024

/pj-rehearse abort

@openshift-ci-robot
Copy link
Contributor

@psturc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@psturc
Copy link
Member

psturc commented May 13, 2024

/pj-rehearse abort

@openshift-ci-robot
Copy link
Contributor

@psturc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@psturc
Copy link
Member

psturc commented May 13, 2024

@psturc any idea what those failures mean?

run make ci-operator-config to address the error in ci-operator-config job

regarding the error in check-gh-automation job - it complains about 'openshift-cherrypick-robot' not having access to the repo. afaik we don't use that bot in our org so I think we can ignore this error

@psturc
Copy link
Member

psturc commented May 13, 2024

@stuartwdouglas otherwise the rehearsal job needs at least these changes to be addressed in order to be successful

@psturc
Copy link
Member

psturc commented May 13, 2024

/test check-gh-automation

@psturc
Copy link
Member

psturc commented May 13, 2024

/verify-owners

@psturc
Copy link
Member

psturc commented May 13, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@psturc
Copy link
Member

psturc commented May 14, 2024

/pj-rehearse pull-ci-redhat-appstudio-multi-platform-controller-main-multi-platform-controller-e2e

@openshift-ci-robot
Copy link
Contributor

@psturc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@psturc
Copy link
Member

psturc commented May 23, 2024

/pj-rehearse pull-ci-redhat-appstudio-multi-platform-controller-main-multi-platform-controller-e2e

@openshift-ci-robot
Copy link
Contributor

@psturc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024
@openshift-ci-robot
Copy link
Contributor

@psturc, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto master: %!w(<nil>)

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • stuartwdouglas
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • ci-operator/config/redhat-appstudio/multi-platform-controller/OWNERS
    • ci-operator/jobs/redhat-appstudio/multi-platform-controller/OWNERS
    • core-services/prow/02_config/redhat-appstudio/multi-platform-controller/OWNERS

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@stuartwdouglas: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-konflux-ci-remote-secret-main-remote-secret-service-e2e konflux-ci/remote-secret presubmit Registry content changed
pull-ci-redhat-appstudio-jvm-build-service-main-jvm-build-service-e2e redhat-appstudio/jvm-build-service presubmit Registry content changed
pull-ci-konflux-ci-release-service-catalog-development-release-pipelines-e2e-suite konflux-ci/release-service-catalog presubmit Registry content changed
pull-ci-konflux-ci-e2e-tests-main-redhat-appstudio-e2e konflux-ci/e2e-tests presubmit Registry content changed
pull-ci-konflux-ci-build-service-main-build-service-e2e konflux-ci/build-service presubmit Registry content changed
pull-ci-redhat-appstudio-multi-platform-controller-main-images redhat-appstudio/multi-platform-controller presubmit Presubmit changed
pull-ci-redhat-appstudio-multi-platform-controller-main-multi-platform-controller-e2e redhat-appstudio/multi-platform-controller presubmit Presubmit changed
pull-ci-konflux-ci-image-controller-main-image-controller-e2e konflux-ci/image-controller presubmit Registry content changed
pull-ci-konflux-ci-service-provider-integration-operator-main-spi-service-e2e konflux-ci/service-provider-integration-operator presubmit Registry content changed
pull-ci-konflux-ci-release-service-main-release-service-e2e konflux-ci/release-service presubmit Registry content changed
pull-ci-redhat-appstudio-application-service-main-application-service-e2e redhat-appstudio/application-service presubmit Registry content changed
pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests redhat-appstudio/infra-deployments presubmit Registry content changed
pull-ci-redhat-appstudio-infra-deployments-main-appstudio-hac-e2e-tests redhat-appstudio/infra-deployments presubmit Registry content changed
pull-ci-redhat-appstudio-infra-deployments-main-appstudio-upgrade-tests redhat-appstudio/infra-deployments presubmit Registry content changed
pull-ci-konflux-ci-integration-service-main-integration-service-e2e konflux-ci/integration-service presubmit Registry content changed
periodic-ci-redhat-appstudio-infra-deployments-main-konflux-openshift-upgrade-periodic N/A periodic Registry content changed
periodic-ci-redhat-appstudio-infra-deployments-main-ocp415-konflux-e2e-v415 N/A periodic Registry content changed
periodic-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests-periodic N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@psturc
Copy link
Member

psturc commented Jun 27, 2024

/pj-rehearse pull-ci-redhat-appstudio-multi-platform-controller-main-multi-platform-controller-e2e

@openshift-ci-robot
Copy link
Contributor

@psturc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@psturc
Copy link
Member

psturc commented Jun 27, 2024

/pj-rehearse pull-ci-redhat-appstudio-multi-platform-controller-main-multi-platform-controller-e2e

@openshift-ci-robot
Copy link
Contributor

@psturc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

psturc
psturc suggested changes Jun 27, 2024
View reviewed changes
...hat-appstudio/multi-platform-controller/redhat-appstudio-multi-platform-controller-main.yaml
owner: rhtap
product: ocp
timeout: 1h0m0s
version: "4.13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've updated all jobs to use 4.14

Suggested change
version: "4.13"
version: "4.14"

...hat-appstudio/multi-platform-controller/redhat-appstudio-multi-platform-controller-main.yaml
release:
architecture: amd64
channel: fast
version: "4.13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "4.13"
version: "4.14"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stuartwdouglas
Once this PR has been reviewed and has the lgtm label, please assign jkopriva for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

@stuartwdouglas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-operator-config-metadata 21f9f52 link true /test ci-operator-config-metadata
ci/rehearse/redhat-appstudio/multi-platform-controller/main/multi-platform-controller-e2e 21f9f52 link unknown /pj-rehearse pull-ci-redhat-appstudio-multi-platform-controller-main-multi-platform-controller-e2e
ci/prow/check-gh-automation 21f9f52 link true /test check-gh-automation

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jul 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 27, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psturc psturc psturc requested changes

@flacatus flacatus Awaiting requested review from flacatus

@jkopriva jkopriva Awaiting requested review from jkopriva

Assignees

@psturc psturc

Labels
do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stuartwdouglas @psturc @openshift-ci-robot @openshift-bot @openshift-merge-robot