Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-1870: Fix the Network Ingress & DNS OWNERS files and add aliases to OWNERS_ALIASES #29247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NE-1870: Fix the Network Ingress & DNS OWNERS files and add aliases to OWNERS_ALIASES #29247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions OWNERS_ALIASES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,25 @@ aliases:
- umohnani8 # Container Engine Tools
- davidvossel # HyperShift on KubeVirt Platform
- orenc1 # HyperShift on KubeVirt Platform
network-ingress-dns-test-case-approvers:
- frobware
- knobunc
- Miciah
- miheer
- alebedev87
- candita
- gcs278
- rfredette
- Thealisyed
- grzpiotrowski
network-ingress-dns-test-case-reviewers:
- frobware
- knobunc
- Miciah
- miheer
- alebedev87
- candita
- gcs278
- rfredette
- Thealisyed
- grzpiotrowski
6 changes: 6 additions & 0 deletions test/extended/dns/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# We use aliases defined in OWNERS_ALIASES

approvers:
- network-ingress-dns-test-case-approvers
reviewers:
- network-ingress-dns-test-case-reviewers
24 changes: 4 additions & 20 deletions test/extended/router/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,9 @@
# We use aliases defined in OWNERS_ALIASES

approvers:
- frobware
- knobunc
- Miciah
- miheer
- alebedev87
- candita
- gcs278
- rfredette
- Thealisyed
- grzpiotrowski
- network-ingress-dns-test-case-approvers
reviewers:
- frobware
- knobunc
- Miciah
- miheer
- alebedev87
- candita
- gcs278
- rfredette
- Thealisyed
- grzpiotrowski
- network-ingress-dns-test-case-reviewers
emeritus_approvers:
- danehans
- sgreene570