Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-14833: E2E: metrics exposed securely #1037

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rbaturov
Copy link
Contributor

@rbaturov rbaturov commented Oct 8, 2024

This is a follow-up PR for #1007 and #1035, adding e2e tests to test their functionality.
The tests verify that secured metrics fetching can be established using kube-rbac-proxy, for both the manager pod and rte workers.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rbaturov rbaturov force-pushed the promethues-tests branch 5 times, most recently from 7422d1d to d0beb3b Compare October 9, 2024 06:58
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbaturov
Once this PR has been reviewed and has the lgtm label, please assign mrniranjan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Added two test to verify that secured metrics fetching can be established using kube-rbac-proxy, for both the manager pod and rte workers.

Signed-off-by: Ronny Baturov <[email protected]>
@rbaturov rbaturov changed the title metrics endpoint test for the operator CNF-14833: E2E: metrics exposed securely Oct 9, 2024
@openshift-ci-robot
Copy link

@rbaturov: This pull request references CNF-14833 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This is a follow-up PR for #1007 and #1035, adding e2e tests to test their functionality.
The tests verify that secured metrics fetching can be established using kube-rbac-proxy, for both the manager pod and rte workers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

@rbaturov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e-install-hypershift 9f47d67 link true /test ci-e2e-install-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants