Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Konflux client, event-sender plugin and must-gather images to CSV #2983

Merged

Conversation

creydr
Copy link
Member

@creydr creydr commented Oct 31, 2024

Adds the Konfluxs builds of :

  • kn-client
  • event-sender plugin and
  • must-gather

to the CSV

@creydr creydr force-pushed the add-konflux-client-builds-to-csv branch from 5e348c7 to f5233d0 Compare November 7, 2024 09:54
@creydr creydr changed the title [WIP] Add Konflux client build to CSV Add Konflux client, event-sender plugin and must-gather images to CSV Nov 7, 2024
@creydr
Copy link
Member Author

creydr commented Nov 7, 2024

/unhold as we have the builds available now

@creydr
Copy link
Member Author

creydr commented Nov 7, 2024

/hold cancel

@mgencur
Copy link
Contributor

mgencur commented Nov 7, 2024

/lgtm

@cardil
Copy link
Member

cardil commented Nov 7, 2024

+1 lgtm

@creydr
Copy link
Member Author

creydr commented Nov 7, 2024

/retest

@creydr
Copy link
Member Author

creydr commented Nov 7, 2024

error: unable to read image image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-index:latest: Get "https://image-registry.openshift-image-registry.svc:5000/v2/": tls: failed to verify certificate: x509: certificate signed by unknown authority

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a0374f8 and 2 for PR HEAD f5233d0 in total

@creydr
Copy link
Member Author

creydr commented Nov 7, 2024

E1107 14:18:57.459171      23 memcache.go:265] couldn't get current server API group list: Get "https://api.serverless-ocp-4-17-amd64-aws-us-east-1-hmjvv.serverless.devcluster.openshift.com:6443/api?timeout=32s": dial tcp: lookup api.serverless-ocp-4-17-amd64-aws-us-east-1-hmjvv.serverless.devcluster.openshift.com on 172.30.0.10:53: no such host
Unable to connect to the server: dial tcp: lookup api.serverless-ocp-4-17-amd64-aws-us-east-1-hmjvv.serverless.devcluster.openshift.com on 172.30.0.10:53: no such host

/test 417-upstream-e2e-aws-417

@openshift-ci openshift-ci bot removed the lgtm label Nov 7, 2024
@creydr
Copy link
Member Author

creydr commented Nov 8, 2024

ERRO[2024-11-08T09:54:56Z] 
  * could not run steps: step serverless-source-image failed: error occurred handling build serverless-source-image-amd64: could not get build serverless-source-image-amd64: builds.build.openshift.io "serverless-source-image-amd64" not found 

/retest

@creydr
Copy link
Member Author

creydr commented Nov 8, 2024

sh-4.4$ /cli/oc -n openshift-serverless get po
NAME                                         READY   STATUS                  RESTARTS   AGE
knative-openshift-5f9657c985-c844w           0/1     Init:ImagePullBackOff   0          4m9s
...
  initContainerStatuses:
  - image: registry.redhat.io/openshift-serverless-1/kn-client-cli-artifacts-rhel8@sha256:82a41eaae2cd8b6004dcb663a2cd359c09fecf646bf5beaec330463abea0ea90
    imageID: ""
    lastState: {}
    name: cli-artifacts
    ready: false
    restartCount: 0
    started: false
    state:
      waiting:
        message: Back-off pulling image "registry.redhat.io/openshift-serverless-1/kn-client-cli-artifacts-rhel8@sha256:82a41eaae2cd8b6004dcb663a2cd359c09fecf646bf5beaec330463abea0ea90"
        reason: ImagePullBackOff

We don't have it in the ICSP, because it's not part of the csv and thus not in the bundle yet:

$ /cli/oc get imagecontentsourcepolicies.operator.openshift.io serverless-image-content-source-policy | grep -i "artifacts"
$  

@creydr creydr force-pushed the add-konflux-client-builds-to-csv branch from 8e324e2 to 77269ec Compare November 8, 2024 12:55
@creydr
Copy link
Member Author

creydr commented Nov 8, 2024

/test 417-test-upgrade-aws-417

@mgencur
Copy link
Contributor

mgencur commented Nov 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2024
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8c7110d and 2 for PR HEAD 77269ec in total

Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

@creydr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-upstream-e2e-kafka-aws-416 5e348c7 link false /test 416-upstream-e2e-kafka-aws-416
ci/prow/416-operator-e2e-aws-416 5e348c7 link true /test 416-operator-e2e-aws-416
ci/prow/416-upstream-e2e-aws-416 5e348c7 link false /test 416-upstream-e2e-aws-416
ci/prow/416-test-upgrade-aws-416 5e348c7 link true /test 416-test-upgrade-aws-416
ci/prow/417-upstream-e2e-kafka-aws-417 77269ec link false /test 417-upstream-e2e-kafka-aws-417

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8bef216 and 1 for PR HEAD 77269ec in total

@creydr creydr merged commit 410b797 into openshift-knative:main Nov 11, 2024
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants