Use istio.sidecar.inject label instead of annotation #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dsimansk
reviewed
Sep 26, 2024
Comment on lines
+92
to
93
| Then, create KnativeService with the `sidecar.istio.io/inject: "true"` label and `sidecar.istio.io/rewriteAppHTTPProbers: "true"`, `serving.knative.openshift.io/enablePassthrough: "true"` annotations in your namespace, | ||
| which is one of the namespaces in the `ServiceMeshMemberRoll`. |
There was a problem hiding this comment.
These doc files are not source of truth for any public content right?
There was a problem hiding this comment.
Yes, not sure why they are there in the first place. Just updated every reference I could find.
|
The only issue I had was answered here knative-extensions/net-istio#1369 (comment) |
|
/unhold |
openshift-merge-bot
bot
merged commit 1155942
into
openshift-knative:main
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA https://issues.redhat.com/browse/SRVKS-1273
Proposed Changes
/assign @skonto