Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using head when getting nodes #2255

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 30, 2023

Prevents errors such as:

 06:52:31.692 INFO:    Placing zipkin taint on first worker node
06:52:32.091 ERROR:   🚨 Error (code: 141) occurred at
./hack/lib/tracing.bash:19, with command: zipkin_node=$(oc get node -l
'node-role.kubernetes.io/worker' -oname | head -n 1)
06:52:32.093 ERROR:   Stack trace:
06:52:32.096 ERROR:    1: ./hack/lib/tracing.bash:6
dedicate_node_to_zipkin(...)
06:52:32.099 ERROR:    2: ./hack/tracing.sh:15 install_tracing(...)
make: *** [test-upgrade-with-mesh] Error 141

Fixes JIRA #

Proposed Changes

Prevents errors such as:
 06:52:31.692 INFO:    Placing zipkin taint on first worker node
06:52:32.091 ERROR:   🚨 Error (code: 141) occurred at
./hack/lib/tracing.bash:19, with command: zipkin_node=$(oc get node -l
'node-role.kubernetes.io/worker' -oname | head -n 1)
06:52:32.093 ERROR:   Stack trace:
06:52:32.096 ERROR:    1: ./hack/lib/tracing.bash:6
dedicate_node_to_zipkin(...)
06:52:32.099 ERROR:    2: ./hack/tracing.sh:15 install_tracing(...)
make: *** [test-upgrade-with-mesh] Error 141
@openshift-ci openshift-ci bot requested review from alanfx and matzew August 30, 2023 08:34
Copy link
Member

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @mgencur

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor Author

mgencur commented Aug 30, 2023

/hold

For upgrade tests to pass

@mgencur
Copy link
Contributor Author

mgencur commented Aug 30, 2023

/unhold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.13-upstream-e2e-kafka-aws-ocp-413 5971987 link false /test 4.13-upstream-e2e-kafka-aws-ocp-413

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3737b52 into openshift-knative:main Aug 30, 2023
3 checks passed
@dsimansk
Copy link
Contributor

/cherry-pick release-1.30

@openshift-cherrypick-robot
Copy link
Contributor

@dsimansk: new pull request created: #2286

In response to this:

/cherry-pick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants