-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using head when getting nodes #2255
Avoid using head when getting nodes #2255
Conversation
Prevents errors such as: 06:52:31.692 INFO: Placing zipkin taint on first worker node 06:52:32.091 ERROR: 🚨 Error (code: 141) occurred at ./hack/lib/tracing.bash:19, with command: zipkin_node=$(oc get node -l 'node-role.kubernetes.io/worker' -oname | head -n 1) 06:52:32.093 ERROR: Stack trace: 06:52:32.096 ERROR: 1: ./hack/lib/tracing.bash:6 dedicate_node_to_zipkin(...) 06:52:32.099 ERROR: 2: ./hack/tracing.sh:15 install_tracing(...) make: *** [test-upgrade-with-mesh] Error 141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @mgencur
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold For upgrade tests to pass |
/unhold |
@mgencur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3737b52
into
openshift-knative:main
/cherry-pick release-1.30 |
@dsimansk: new pull request created: #2286 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Prevents errors such as:
Fixes JIRA #
Proposed Changes