Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade tests with ServiceMesh #2254

Merged
merged 9 commits into from
Sep 4, 2023
Merged

Fix upgrade tests with ServiceMesh #2254

merged 9 commits into from
Sep 4, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 29, 2023

This is to test https://issues.redhat.com/browse/SRVKS-1080 and to see if this still happens

Fixes JIRA #

Proposed Changes

@mgencur mgencur changed the title [WIP] Test: test-upgrade is alias for test-upgrade-with-mesh [WIP] Re-test Service temporarily unavailable during upgrades with Service Mesh Aug 29, 2023
@mgencur
Copy link
Contributor Author

mgencur commented Aug 29, 2023

/test 4.13-upgrade-tests-aws-ocp-413

1 similar comment
@mgencur
Copy link
Contributor Author

mgencur commented Aug 30, 2023

/test 4.13-upgrade-tests-aws-ocp-413

@mgencur
Copy link
Contributor Author

mgencur commented Sep 1, 2023

The upgrade test is now passing.
I will remove the alias test-upgrade: test-upgrade-with-mesh and get this PR ready for merging with the next commit.

@mgencur mgencur changed the title [WIP] Re-test Service temporarily unavailable during upgrades with Service Mesh Fix upgrades tests with ServiceMesh Sep 1, 2023
@mgencur mgencur changed the title Fix upgrades tests with ServiceMesh Fix upgrade tests with ServiceMesh Sep 1, 2023
@mgencur
Copy link
Contributor Author

mgencur commented Sep 1, 2023

/test 4.13-upstream-e2e-aws-ocp-413

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023 •
edited
Loading

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.13-upstream-e2e-kafka-aws-ocp-413 0c679a2 link false /test 4.13-upstream-e2e-kafka-aws-ocp-413

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mgencur
Copy link
Contributor Author

mgencur commented Sep 1, 2023

/test 4.13-upstream-e2e-kafka-aws-ocp-413

ReToCode
ReToCode approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Sep 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ff329d5 into openshift-knative:main Sep 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@aliok aliok Awaiting requested review from aliok

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

Assignees

@ReToCode ReToCode

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgencur @ReToCode @openshift-merge-robot