Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable cgroups tests on OCP 4.14+ (#2210)" #2253

Merged

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 29, 2023

This reverts commit 400fa91.

The necessary changes for the CGroups test were merged as part of openshift-knative/serving#428

Related to https://issues.redhat.com/browse/SRVKS-1111

Proposed Changes

This reverts commit 400fa91.

The necessary changes for the CGroups test were merged as part of openshift-knative/serving#428
@openshift-ci openshift-ci bot requested review from aliok and matzew August 29, 2023 06:15
@mgencur
Copy link
Contributor Author

mgencur commented Aug 29, 2023

/assign @nak3

@nak3
Copy link
Contributor

nak3 commented Aug 29, 2023

/lgtm
/approve
/hold for openshift-knative/serving#431 will be merged just in case.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Contributor

nak3 commented Aug 29, 2023

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit e85c447 into openshift-knative:main Aug 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants