Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a var for eventing test image repo #2237

Merged

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 16, 2023

Follow up on #2235 (comment)

Signed-off-by: Christoph Stäbler <[email protected]>
@creydr
Copy link
Member Author

creydr commented Aug 16, 2023

/assign @mgencur

@mgencur
Copy link
Contributor

mgencur commented Aug 16, 2023

/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm label Aug 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dd14a2b into openshift-knative:main Aug 16, 2023
3 checks passed
@creydr creydr deleted the use-var-for-quay-repo branch May 23, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants