-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Serving service mesh tests more stable #2196
Make Serving service mesh tests more stable #2196
Conversation
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
/test 4.10-upstream-e2e-mesh-aws-ocp-410 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for tests |
/test 4.10-upstream-e2e-mesh-aws-ocp-410 |
1 similar comment
/test 4.10-upstream-e2e-mesh-aws-ocp-410 |
/unhold Eventing failures are flakes |
👍 I'll add that then, but after 4.13-upstream-e2e-mesh-aws-ocp-413 is hopefully green once :) |
@ReToCode: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
92226e1
into
openshift-knative:main
Fixes JIRA https://issues.redhat.com/browse/SRVCOM-2356
Partially fixes JIRA https://issues.redhat.com/browse/SRVKS-1099
Partially fixes JIRA https://issues.redhat.com/browse/SRVCOM-2522
Proposed Changes
We are trying to do #2171 in parts now. This PR contains the fixes found in https://issues.redhat.com/browse/SRVKS-1099 to make Serving service-mesh tests more stable
Changes:
TERMINATION_DRAIN_DURATION_SECONDS
from metadata-webhook, as this no longer worksterminationDrainDuration: 35s
to SMCP to make envoy wait longer with termination/cc @mgencur , @pierDipi