Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventing core 1.10 bump #2181

Closed
wants to merge 4 commits into from

Conversation

matzew
Copy link
Member

@matzew matzew commented Jul 24, 2023

Proposed Changes

  • as per title

@openshift-ci openshift-ci bot requested review from pierDipi and skonto July 24, 2023 08:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Member

You'll probably also need #2182 to make upgrade tests pass.

@matzew
Copy link
Member Author

matzew commented Jul 24, 2023

Thanks for the heads, up @ReToCode

@matzew
Copy link
Member Author

matzew commented Jul 24, 2023

Rebased this PR

@matzew
Copy link
Member Author

matzew commented Jul 24, 2023

/test 4.13-operator-e2e-aws-ocp-413

1 similar comment
@matzew
Copy link
Member Author

matzew commented Jul 24, 2023

/test 4.13-operator-e2e-aws-ocp-413

@matzew
Copy link
Member Author

matzew commented Jul 24, 2023

/retest

@matzew
Copy link
Member Author

matzew commented Jul 24, 2023

    user_permissions.go:51: Unexpected error creating eventing.knative.dev/v1, Resource=brokers, allowed = false, err = <nil>

that does not make sense. Or was there some change I am not aware of?

@matzew
Copy link
Member Author

matzew commented Jul 25, 2023

/retest

Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
@creydr
Copy link
Member

creydr commented Jul 31, 2023

/test 4.13-operator-e2e-aws-ocp-413

@matzew
Copy link
Member Author

matzew commented Jul 31, 2023

/retest

1 similar comment
@matzew
Copy link
Member Author

matzew commented Aug 2, 2023

/retest

@pierDipi
Copy link
Member

pierDipi commented Aug 2, 2023

On https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-knative_serverless-operator/2181/pull-ci-openshift-knative-serverless-operator-main-4.13-operator-e2e-aws-ocp-413/1686087370740338688/artifacts/operator-e2e-aws-ocp-413/gather-extra/artifacts/pods.json

                "containerStatuses": [
                    {
                        "image": "quay.io/openshift-knative/knative-eventing-storage-version-migration:knative-v1.10",
                        "imageID": "",
                        "lastState": {},
                        "name": "migrate",
                        "ready": false,
                        "restartCount": 0,
                        "started": false,
                        "state": {
                            "waiting": {
                                "message": "Back-off pulling image \"quay.io/openshift-knative/knative-eventing-storage-version-migration:knative-v1.10\"",
                                "reason": "ImagePullBackOff"
                            }
                        }
                    }
                ],

1.10 image is not mirrored https://quay.io/repository/openshift-knative/knative-eventing-storage-version-migration?tab=tags&tag=knative-v1.10

@matzew
Copy link
Member Author

matzew commented Aug 2, 2023

this fails:

podman pull registry.ci.openshift.org/openshift/knative-eventing-storage-version-migration:knative-v1.10
Trying to pull registry.ci.openshift.org/openshift/knative-eventing-storage-version-migration:knative-v1.10...
Error: initializing source docker://registry.ci.openshift.org/openshift/knative-eventing-storage-version-migration:knative-v1.10: reading manifest knative-v1.10 in registry.ci.openshift.org/openshift/knative-eventing-storage-version-migration: manifest unknown
➜  ~ 

Signed-off-by: Matthias Wessendorf <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@matzew: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.13-upstream-e2e-aws-ocp-413 309149e link false /test 4.13-upstream-e2e-aws-ocp-413

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matzew
Copy link
Member Author

matzew commented Aug 2, 2023

/test 4.13-upstream-e2e-aws-ocp-413

@matzew
Copy link
Member Author

matzew commented Aug 2, 2023

/close

let's do it via #2192

@openshift-ci openshift-ci bot closed this Aug 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@matzew: Closed this PR.

In response to this:

/close

let's do it via #2192

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants