-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added High Level Rest Client for SDK #306
Added High Level Rest Client for SDK #306
Conversation
Signed-off-by: Owais Kazi <[email protected]>
0f69246
to
5b63373
Compare
Signed-off-by: Owais Kazi <[email protected]>
5b63373
to
3ff4b65
Compare
Signed-off-by: Owais Kazi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
============================================
- Coverage 73.22% 72.97% -0.26%
- Complexity 117 120 +3
============================================
Files 25 25
Lines 508 518 +10
Branches 15 15
============================================
+ Hits 372 378 +6
- Misses 128 131 +3
- Partials 8 9 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditionally approved (where I'll tweak it later) given your time constraints, but some suggestions I'd like handled if you have the time.
7bf6921
to
82ba7e2
Compare
Signed-off-by: Owais Kazi <[email protected]>
82ba7e2
to
18971a6
Compare
* Added High Level Rest Client for SDK Signed-off-by: Owais Kazi <[email protected]> * Updates method name Signed-off-by: Owais Kazi <[email protected]> * Addressed PR Comments Signed-off-by: Owais Kazi <[email protected]> * Implements Closeable for SDKClients Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi [email protected]
Description
Added High Level Rest Client for SDK
Issues Resolved
Part of #294 and #302
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.