Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter to the migration cdk stack #1108

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

peternied
Copy link
Member

Description

As ESLint to the migrations cdk stack

Issues Resolved

Testing

Ran npm run test:lint from the console,

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.55%. Comparing base (4769ba4) to head (e6e854a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1108   +/-   ##
=========================================
  Coverage     80.55%   80.55%           
  Complexity     2930     2930           
=========================================
  Files           390      390           
  Lines         14462    14462           
  Branches        998      998           
=========================================
  Hits          11650    11650           
  Misses         2209     2209           
  Partials        603      603           
Flag Coverage Δ
gradle-test 78.63% <ø> (ø)
python-test 90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait
Copy link
Member

How is formatting performed? It's not clear to me if how to fix any linting failures automatically

@peternied
Copy link
Member Author

How is formatting performed? It's not clear to me if how to fix any linting failures automatically

I might misunderstand, this isn't a formatter, its trying to prevent !best-practices in the javascript/typescript code, such as not using any and using a specific type instead. There isn't a clean mapping for the proper behavior in that scenario.

I manually added comments so we can start enforcing the linter on new code and clean up when we make changes on old items.

@peternied peternied merged commit e526ae0 into opensearch-project:main Oct 29, 2024
14 checks passed
@peternied peternied deleted the lint-ma branch October 29, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants