-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create RFS successor work items #1104
Merged
mikaylathompson
merged 20 commits into
opensearch-project:main
from
mikaylathompson:successor-work-items
Nov 13, 2024
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
31ae47d
Fix bug in numWorkItemsArePending
mikaylathompson e48005b
Just switch to _count
mikaylathompson ab9b653
_count -> _search
mikaylathompson 1a926d1
Rename for clarity (pending->notYetCompleted)
mikaylathompson f573157
Add extra check around the uncertain case if hits==0
mikaylathompson 89198da
Main logic and tests for successor work items
mikaylathompson 9af9db4
Add another check to never change the successor items
mikaylathompson 10b0ede
Integrate into workflow (anytime a worker picks up a work item with s…
mikaylathompson 2c2c79c
Merge branch 'main' into successor-work-items
mikaylathompson dfb8183
Merge branch 'main' into successor-work-items
mikaylathompson ddb9c33
Handle retries and an edge case
mikaylathompson 0f6d6ee
spotless fixes
mikaylathompson bd44697
Addressing review comments
mikaylathompson ae2d1dd
Additional review updates
mikaylathompson 4c0acb6
Clean up scopedworkcoordinator modifications
mikaylathompson ab751db
Next round of review
mikaylathompson 2a29476
Fix tests for new acquireNextWorkItem behavior
mikaylathompson cdfc72c
Merge branch 'main' into successor-work-items
AndreKurait 0cbe935
Merge branch 'main' into successor-work-items
AndreKurait 9320855
Merge branch 'main' into successor-work-items
AndreKurait File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigh - it took me a few minutes to remember what we're refreshing... and it's the server.
nit: Maybe rename this whole term from refresh to something like refreshIndexOnCluster (that could be a separate PR, but it could be a 10 minute refactoring change now)