Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reindexFromSnapshotWorkerSize to cdk with default and maximum modes #1085

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Oct 21, 2024

Description

Added an RFS High Performance Mode that does the following:

  • Increases EBS Throughput for faster s3 download and extract
  • Increases worker size to 16vCPU 32GB
  • Sets max concurrent requests to 100
  • Enables Target Compression

With these settings, i was able to use 5 workers to migrate a 5 shard source where each source shard was 1.9TiB (9.2TiB total) in 7 hours with a target cluster composed of 10 r7gd.16xlarge data nodes (Increased target index shard count to 400).

Also improved the UX by adding a buffer on max shard size which can reduce friction when shards are slightly uneven and a customer calculated their max shard size by taking primary size / shards.

Also fixed a bug in imageHash for builds with "docker-compatible" clients like podman when image Id just returns the hash and not a :.

  • Category: New Feature
  • Why these changes are required? Enable vertical scaling when horizontal scaling is limited
  • What is the old behavior before changes and new behavior after changes? Vertical scaling not supported, now supported

Issues Resolved

MIGRATIONS-2144

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Testing: With these settings, i was able to use 5 workers to migrate a 5 shard source where each source shard was 1.9TiB (9.2TiB total) in 7 hours with a target cluster composed of 10 r7gd.16xlarge data nodes (Increased target index shard count to 400).

Added unit testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (e2c5be7) to head (aab31a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1085   +/-   ##
=========================================
  Coverage     80.66%   80.66%           
  Complexity     2893     2893           
=========================================
  Files           383      383           
  Lines         14361    14361           
  Branches        989      989           
=========================================
  Hits          11584    11584           
  Misses         2184     2184           
  Partials        593      593           
Flag Coverage Δ
gradle-test 78.75% <ø> (ø)
python-test 90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit db0075e into opensearch-project:main Oct 21, 2024
14 checks passed
@AndreKurait AndreKurait deleted the HighPerformanceMode branch October 21, 2024 17:09
gregschohn pushed a commit to gregschohn/opensearch-migrations that referenced this pull request Oct 24, 2024
gregschohn pushed a commit to gregschohn/opensearch-migrations that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants