-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove required check on indices.stats.ShardStats.shards #1177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment and reminder
java-client/src/main/java/org/opensearch/client/opensearch/indices/stats/ShardStats.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please add a test.
java-client/src/main/java/org/opensearch/client/opensearch/indices/stats/ShardStats.java
Outdated
Show resolved
Hide resolved
java-client/src/main/java/org/opensearch/client/opensearch/indices/stats/ShardStats.java
Show resolved
Hide resolved
2c5205c
to
93ebd81
Compare
93ebd81
to
cb89246
Compare
Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]>
Signed-off-by: Liam Macpherson <[email protected]>
Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]>
Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]>
Signed-off-by: Liam Macpherson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking with this @LiamMacpherson, the changes look good, just need to fix the formatting to keep the CI happy.
Could you please run and commit the changes:
./gradlew spotlessApply
Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]>
Ah -- I hadn't noticed that failure! Thanks for highlighting @Xtansia! |
Thanks @LiamMacpherson |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1177-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8a37f3f2776f5ef2244382c6bc379747e05f203e
# Push it to GitHub
git push --set-upstream origin backport/backport-1177-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…arch-project#1177) * fix: remove required check on indices.stats.ShardStats.shards Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> * address review comments re: imports and changelog Signed-off-by: Liam Macpherson <[email protected]> * add test and remove check in constructor Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> * re-remove auto import organisation Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> * chore: correct changelog link Signed-off-by: Liam Macpherson <[email protected]> * spotlessApply tidyup Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> --------- Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> (cherry picked from commit 8a37f3f)
…#1200) * fix: remove required check on indices.stats.ShardStats.shards Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> * address review comments re: imports and changelog Signed-off-by: Liam Macpherson <[email protected]> * add test and remove check in constructor Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> * re-remove auto import organisation Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> * chore: correct changelog link Signed-off-by: Liam Macpherson <[email protected]> * spotlessApply tidyup Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> --------- Signed-off-by: Liam Macpherson <[email protected]> Signed-off-by: Liam Macpherson <[email protected]> (cherry picked from commit 8a37f3f) Co-authored-by: Liam Macpherson <[email protected]>
Description
This change addresses the problem wherein we require a field which isn't ever returned inside the "Shards" property on indices stats calls with the level set to "shards".
Issues Resolved
Closes 1174
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.