Add test cases for workspace creation #1635
Open
+97
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Kapian1234
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
wanglam
reviewed
Nov 13, 2024
| .closest('.euiCheckableCard-isChecked') | ||
| .should('exist'); | ||
|
|
||
| miscUtils.visitPage('app/workspace_initial'); |
There was a problem hiding this comment.
Why we need to visit initial page twice?
There was a problem hiding this comment.
to check if both these buttons could navigate to the create page
There was a problem hiding this comment.
I don't think the workspace create integration test should cover this part. But it's OK. We can keep this.
| }); | ||
| }); | ||
|
|
||
| it('should successfully jump to collaborators page after creating a workspace', () => { |
There was a problem hiding this comment.
Prefer adding SECURITY_ENABLED and SAVED_OBJECTS_PERMISSION_ENABLED check before this test case.
| cy.contains(workspaceName).should('exist'); | ||
| cy.contains('test_workspace_description.+~!').should('exist'); | ||
| cy.contains('Essentials').should('exist'); | ||
| cy.contains(dataSourceTitle).should('exist'); |
There was a problem hiding this comment.
Need to add MDSEnabled check here.
Signed-off-by: Kapian1234 <[email protected]>
wanglam
reviewed
Nov 13, 2024
| }); | ||
| } | ||
|
|
||
| if (MDSEnabled) { |
There was a problem hiding this comment.
I think we should move this MDSEnabled check to line 187. We should test the summary card display for name and description if MDS not enabled.
Signed-off-by: Kapian1234 <[email protected]>
…ashboards-functional-test into workspace_create
SuZhou-Joe
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.