-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AL2 ci images with unofficial nodejs build before EOL deprecation #5178
Comments
Apparently we can get over it with one more params, apart from
|
Apparently checkout@v4 up to node20 but upload/download artifacts only up to 18/12 respectively. |
Seems like github prevent you from even using your own nodejs binaries to run actions:
|
Even if you install nodejs 18 or 20 that is custom build and compatible with AL2 on docker images, github will enforce on using their host version of node binaries during action runs. I am not seeing a good method to override that at the moment. |
Seems we can force with setup-node actions to some degree: |
Some already proposed: |
More deep dive and seems like happening since this where all node16 has been updated to node20. This pretty much means these params are not taking effect anymore:
|
See descriptions for all the fix PRs. |
A lot of the github actions are failing now due to AL2 with older glibc does not support node 18 and 20 and above. (Ex: opensearch-project/job-scheduler#700) (Ex2: opensearch-project/neural-search#975)
Since AL2 will be deprecated on 2025/06 we opt to use the unofficial build to unblock us from this situation without doing too much changes to everyone's checks.
Thanks.
New Approach:
Therefore the actions of v4s will then use our binary to run, which support glibc2.17.
Plugin Owners, please follow this Sample PR to mitigate the issues:
Thanks!
Fix Mechanism PRs:
Infra/Plugin PRs:
The text was updated successfully, but these errors were encountered: