Skip to content

Commit

Permalink
Update the spec to string
Browse files Browse the repository at this point in the history
Signed-off-by: Zelin Hao <[email protected]>
  • Loading branch information
zelinh committed Oct 31, 2024
1 parent 053cf63 commit 2d18799
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions src/manifests/test_manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ class TestManifest(ComponentManifest['TestManifest', 'TestComponents']):
- with-security
- without-security
smoke-test:
test-spec:
- spec.yaml
test-spec: spec.yaml
"""

SCHEMA = {
Expand Down Expand Up @@ -94,7 +93,7 @@ class TestManifest(ComponentManifest['TestManifest', 'TestComponents']):
"smoke-test": {
"type": "dict",
"schema": {
"test-spec": {"type": "list"},
"test-spec": {"type": "string"},
},
},
},
Expand Down
3 changes: 1 addition & 2 deletions tests/tests_manifests/data/opensearch-2.18.0-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ ci:
components:
- name: opensearch
smoke-test:
test-spec:
- opensearch.yml
test-spec: opensearch.yml
- name: alerting
integ-test:
test-configs:
Expand Down
2 changes: 1 addition & 1 deletion tests/tests_manifests/test_test_manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_component(self) -> None:
self.assertEqual(component_as.bwc_test, {"test-configs": ["with-security"]})
component_os = self.manifest.components["opensearch"]
self.assertEqual(component_os.name, "opensearch")
self.assertEqual(component_os.smoke_test, {"test-spec": ["opensearch.yml"]})
self.assertEqual(component_os.smoke_test, {"test-spec": "opensearch.yml"})

def test_component_with_working_directory(self) -> None:
component = self.manifest.components["notifications"]
Expand Down

0 comments on commit 2d18799

Please sign in to comment.