Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gradle to 8.10.2 #3139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Gradle to 8.10.2 #3139

wants to merge 1 commit into from

Conversation

reta
Copy link
Contributor

@reta reta commented Oct 22, 2024

Description

Update Gradle to 8.10.2

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 22, 2024 18:03 — with GitHub Actions Failure
@reta reta temporarily deployed to ml-commons-cicd-env-require-approval October 22, 2024 18:03 — with GitHub Actions Inactive
@reta
Copy link
Contributor Author

reta commented Oct 22, 2024

@dhrubo-os Please add 2.x backport label, thank you!

@dhrubo-os
Copy link
Collaborator

@dhrubo-os Please add 2.x backport label, thank you!

Added.

@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 22, 2024 21:21 — with GitHub Actions Failure
@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 22, 2024 23:57 — with GitHub Actions Failure
@reta reta temporarily deployed to ml-commons-cicd-env-require-approval October 23, 2024 20:52 — with GitHub Actions Inactive
@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2024 21:52 — with GitHub Actions Failure
@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2024 22:45 — with GitHub Actions Failure
@dhrubo-os
Copy link
Collaborator

The last test suite is failing due to:

Error: Unable to download artifact(s): Artifact not found for name: ml-plugin-linux-21
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

@reta any suggestion?

@reta
Copy link
Contributor Author

reta commented Oct 24, 2024

@reta any suggestion?

Interesting, I will take a look shortly, thanks @dhrubo-os

@reta
Copy link
Contributor Author

reta commented Oct 24, 2024

@dhrubo-os seems like an intermittent issue :(

@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 24, 2024 16:32 — with GitHub Actions Failure
@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 24, 2024 17:01 — with GitHub Actions Failure
@dhrubo-os
Copy link
Collaborator

@dhrubo-os seems like an intermittent issue :(

This doesn't seem like an intermittent issue, as every time I run the test, it kept failing with:

Error: Unable to download artifact(s): Artifact not found for name: ml-plugin-linux-21
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Run actions/[email protected]

@peterzhuamazon do you have any idea on this?

@peterzhuamazon
Copy link
Member

@dhrubo-os seems like an intermittent issue :(

This doesn't seem like an intermittent issue, as every time I run the test, it kept failing with:

Error: Unable to download artifact(s): Artifact not found for name: ml-plugin-linux-21
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Run actions/[email protected]

@peterzhuamazon do you have any idea on this?

You should change your upload artifact action to v4:
actions/download-artifact#358

I dont know if it failing now but try the latest version of both upload and download.

@dhrubo-os dhrubo-os mentioned this pull request Oct 24, 2024
Merged
5 tasks
@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 24, 2024 18:56 — with GitHub Actions Failure
@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 24, 2024 18:56 — with GitHub Actions Failure
@reta
Update Gradle to 8.10.2
c9b9082 
Signed-off-by: Andriy Redko <[email protected]>
@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 24, 2024 19:02 — with GitHub Actions Failure
@reta reta temporarily deployed to ml-commons-cicd-env-require-approval October 24, 2024 19:02 — with GitHub Actions Inactive
@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 24, 2024 21:10 — with GitHub Actions Failure
@reta reta had a problem deploying to ml-commons-cicd-env-require-approval October 24, 2024 22:14 — with GitHub Actions Failure
@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Oct 28, 2024 •
edited
Loading

@reta @peterzhuamazon after upgrading upload artifact to v4, now this workflow is failing due to :


/usr/bin/docker exec  21c52b88320a9f9856ba0051c16d01ee574c33177d6ec96f5923a0df05061395 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

I ran the workflow a few times and same failure.

@peterzhuamazon
Copy link
Member

@reta @peterzhuamazon after upgrading upload artifact to v4, now this workflow is failing due to :


/usr/bin/docker exec  21c52b88320a9f9856ba0051c16d01ee574c33177d6ec96f5923a0df05061395 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

I ran the workflow a few times and same failure.

Well then, expected because AL2 does not support node18+

@peterzhuamazon
Copy link
Member

Maybe the workflows needs to be updated to a different method until next year that we deprecate AL2.

@dhrubo-os
Copy link
Collaborator

Maybe the workflows needs to be updated to a different method until next year that we deprecate AL2.

But now our linux Integ tests are failing. Should I downgrade to V3 then?

@peterzhuamazon
Copy link
Member

Try this
https://github.com/opensearch-project/sql/blob/3b8661201efe893cd80da5f8dbd3b21333a8eda9/.github/workflows/sql-test-and-build-workflow.yml#L32-L33

https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrubo-os dhrubo-os dhrubo-os left review comments

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@samuel-oci samuel-oci Awaiting requested review from samuel-oci samuel-oci is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reta @dhrubo-os @peterzhuamazon