Return instance of LockService from createComponents #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
joshpalis,
saratvemulapalli,
dbwiddis,
kaituo,
vibrantvarun and
prudhvigodithi
as code owners
|
Eventually, the LockService's constructor should change visibility so that plugins cannot directly instantiate this class. |
cwperks
changed the title
5 tasks
prudhvigodithi
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 5bbe395) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks
pushed a commit
that referenced
this pull request
Sep 4, 2024
(cherry picked from commit 5bbe395) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small PR to return the LockService instance that's initialized with
JobSchedulerPlugin.createComponentsas one of the JobScheduler components so that it is injectable via Guice to plugins that rely on the JS SPI.Tested this by making GeoSpatial into a ClusterPlugin and verified that the LockService is injectable with Guice. See companion geospatial PR here: opensearch-project/geospatial#677
This PR is part of an effort to remove usages of ThreadContext.stashContext across the plugins: opensearch-project/opensearch-plugins#238
Currently, plugins like geospatial instantiate their own instance of the LockService by passing in the Client given to the plugin through
createComponents.As part of the effort to Strengthen System Indices in the Plugin Ecosystem, plugins will be restricted to only perform transport actions to their own system indices. This PR is to ensure that plugins like Geospatial can re-use the LockService instantiated by JS (which has permission to JS system indices) vs creating its own LockService.
Related Issues
Related to opensearch-project/security#4439
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.