Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]feat: update category to flatten menus in analytics(all) use case #448

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Sep 26, 2024

Description

Based on opensearch-project/OpenSearch-Dashboards#8332, reporting needs to make some adjustment to flatten the menus in analytics(all) use case.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <[email protected]>
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is failing for a while/not related to this change. Test was not succeeding before because of outdated workflow. We should follow up on the snapshot failure.

@derek-ho derek-ho merged commit f50ed4c into opensearch-project:main Sep 30, 2024
3 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 30, 2024
…use case (#448)

* feat: update category

Signed-off-by: SuZhou-Joe <[email protected]>

* Bump upload artifact version

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
(cherry picked from commit f50ed4c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho added a commit that referenced this pull request Sep 30, 2024
…use case (#448) (#456)

* feat: update category



* Bump upload artifact version



---------




(cherry picked from commit f50ed4c)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Derek Ho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants