Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency jsdom to v18 #381

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

mend-for-github-com[bot]
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
jsdom dependencies major 17.0.0 -> 18.0.0

By merging this PR, the below issues will be automatically resolved and closed:

Severity CVSS Score CVE GitHub Issue
High 7.5 CVE-2024-37890 #377

Release Notes

jsdom/jsdom (jsdom)

v18.0.0

Compare Source

Potentially-breaking bug fixes:

  • Fixed SSL certificate checking for WebSocket connections. Previously, invalid SSL certificates were always accepted; now, they properly respect the ResourceLoader's strictSSL option (which defaults to true).
  • Changed the global in which almost all Promise and TypeError instances are created to be the jsdom global, not the Node.js global. This could affect any code that uses instanceof.

Other changes:

  • Fixed moving an element between HTML and XML documents to reset the tagName cache, allowing it to return a lowercase value once it's in the XML document. (LucasLefevre)
  • Fixed form submission to not happen when the form is invalid. (pozil)

  • If you want to rebase/retry this PR, check this box

@rupal-bq rupal-bq merged commit 7843bd3 into main Jul 22, 2024
18 of 19 checks passed
@mend-for-github-com mend-for-github-com bot deleted the whitesource-remediate/jsdom-18.x branch July 22, 2024 20:50
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-reporting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-reporting/backport-2.x
# Create a new branch
git switch --create backport/backport-381-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7843bd3a87293607f39b10a777439f7fafcba951
# Push it to GitHub
git push --set-upstream origin backport/backport-381-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-reporting/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-381-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants