Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support MDS in feature anywhere #767

Merged
merged 1 commit into from
Jun 3, 2024
Merged

support MDS in feature anywhere #767

merged 1 commit into from
Jun 3, 2024

Conversation

jackiehanyang
Copy link
Collaborator

@jackiehanyang jackiehanyang commented Jun 2, 2024 •
edited
Loading

Description

support MDS in feature anywhere, including the following changes:

  • create/list detector with dataSourceId
  • when creating the saved object, include the dataSourceId as an argument together with detectorId.
  • reading the dataSourceId in overlay_anomalies file from the saved object together with detectorId
Screen.Recording.2024-04-22.at.10.26.48.mov

Issues Resolved

#731

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jackiehanyang jackiehanyang merged commit 1eebf24 into opensearch-project:main Jun 3, 2024
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 3, 2024
@jackiehanyang @github-actions
support MDS in feature anywhere (#767)
54b651b 
Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 1eebf24)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 3, 2024
Merged
jackiehanyang added a commit that referenced this pull request Jun 3, 2024
@opensearch-trigger-bot @jackiehanyang
support MDS in feature anywhere (#767) (#768)
0966a2f 
Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 1eebf24)

Co-authored-by: Jackie Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpalis joshpalis joshpalis approved these changes

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackiehanyang @owaiskazi19 @joshpalis