Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add faster scaling composite hash value encoding for remote path #13424

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

ashking94
Copy link
Member

Backport 02f9d74 from #13251.

@ashking94
Copy link
Member Author

There was conflict in ClusterSettings class.

@ashking94
Copy link
Member Author

Detect Breaking Changes failing on changes that have not been released in any version yet.

***! MODIFIED ENUM: PUBLIC ABSTRACT STATIC org.opensearch.index.remote.RemoteStoreEnums$PathHashAlgorithm  (field removed)
	===  CLASS FILE FORMAT VERSION: 55.0 <- 55.0
	---! REMOVED FIELD: PUBLIC(-) STATIC(-) FINAL(-) org.opensearch.index.remote.RemoteStoreEnums$PathHashAlgorithm FNV_1A
	+++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) org.opensearch.index.remote.RemoteStoreEnums$PathHashAlgorithm FNV_1A_COMPOSITE_1
	+++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) org.opensearch.index.remote.RemoteStoreEnums$PathHashAlgorithm FNV_1A_BASE64
***! MODIFIED CLASS: PUBLIC org.opensearch.indices.IndicesService  (not serializable)
	===  CLASS FILE FORMAT VERSION: 55.0 <- 55.0
	---! REMOVED FIELD: PUBLIC(-) STATIC(-) FINAL(-) org.opensearch.common.settings.Setting<org.opensearch.index.remote.RemoteStoreEnums$PathType> CLUSTER_REMOTE_STORE_PATH_PREFIX_TYPE_SETTING
	+++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) org.opensearch.common.settings.Setting<org.opensearch.index.remote.RemoteStoreEnums$PathHashAlgorithm> CLUSTER_REMOTE_STORE_PATH_HASH_ALGORITHM_SETTING
	+++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) org.opensearch.common.settings.Setting<org.opensearch.index.remote.RemoteStoreEnums$PathType> CLUSTER_REMOTE_STORE_PATH_TYPE_SETTING

Copy link
Contributor

✅ Gradle check result for a6deda5: SUCCESS

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.13%. Comparing base (0dd892c) to head (a6deda5).
Report is 196 commits behind head on 2.x.

Files Patch % Lines
.../org/opensearch/index/remote/RemoteStoreUtils.java 72.72% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13424      +/-   ##
============================================
- Coverage     71.28%   71.13%   -0.16%     
- Complexity    60145    60765     +620     
============================================
  Files          4957     5015      +58     
  Lines        282799   286150    +3351     
  Branches      41409    41820     +411     
============================================
+ Hits         201591   203546    +1955     
- Misses        64189    65425    +1236     
- Partials      17019    17179     +160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 4b3b232 into opensearch-project:2.x Apr 27, 2024
50 of 52 checks passed
@ashking94 ashking94 deleted the backport-2.x-13251 branch April 27, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants