Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Get value of query from query editor instead of props #8795

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Nov 2, 2024

Description

Not able to recreate the issue where if in DQL and press Enter then the text field is automatically cleared out. Not positive if this will resolve this issue but it feels inaccurate to submit the props.query instead of relying on the value of the query

Issues Resolved

n/a

Screenshot

Testing the changes

Changelog

  • fix: [Discover] get query value from editor on submit instead of query state

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Nov 2, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@kavilla kavilla changed the title WIP: not able to recreate issue where enter wipes the query clear but fix for taking value WIP: get value of query from query editor instead of props Nov 2, 2024
Copy link
Contributor

github-actions bot commented Nov 2, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (5829303) to head (a906a18).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8795   +/-   ##
=======================================
  Coverage   60.77%   60.77%           
=======================================
  Files        3798     3798           
  Lines       90695    90695           
  Branches    14279    14279           
=======================================
+ Hits        55121    55123    +2     
+ Misses      32075    32074    -1     
+ Partials     3499     3498    -1     
Flag Coverage Δ
Linux_1 29.05% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.64% <ø> (+<0.01%) ⬆️
Linux_4 29.82% <ø> (ø)
Windows_1 29.07% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.64% <ø> (+<0.01%) ⬆️
Windows_4 29.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashwin-pc
ashwin-pc previously approved these changes Nov 2, 2024
@ashwin-pc ashwin-pc changed the title WIP: get value of query from query editor instead of props [Discover] Get value of query from query editor instead of props Nov 3, 2024
Copy link
Contributor

github-actions bot commented Nov 3, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants