-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Get value of query from query editor instead of props #8795
base: main
Are you sure you want to change the base?
[Discover] Get value of query from query editor instead of props #8795
Conversation
… fix for taking value Signed-off-by: Kawika Avilla <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8795 +/- ##
=======================================
Coverage 60.77% 60.77%
=======================================
Files 3798 3798
Lines 90695 90695
Branches 14279 14279
=======================================
+ Hits 55121 55123 +2
+ Misses 32075 32074 -1
+ Partials 3499 3498 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Description
Not able to recreate the issue where if in DQL and press
Enter
then the text field is automatically cleared out. Not positive if this will resolve this issue but it feels inaccurate to submit the props.query instead of relying on the value of the queryIssues Resolved
n/a
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration