Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shdict set_when, safe_set_when, and store_when #171

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hnakamur
Copy link

@hnakamur hnakamur commented Aug 7, 2019

This pull request adds set_when and safe_set_when methods to ngx.shared.DICT.
It also adds ngx_stream_lua_ffi_shdict_store_when which is used in Add shdict set_when and safe_set_when by hnakamur · Pull Request #268 · openresty/lua-resty-core.

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-resty-core project.

@hnakamur
Copy link
Author

hnakamur commented Aug 8, 2019

Test with the following pull request fails at https://travis-ci.org/hnakamur/stream-lua-nginx-module/builds/569568232

https://travis-ci.org/hnakamur/stream-lua-nginx-module/jobs/569568238

#   Failed test 'TEST 5: lua_load_resty_core 'on' in stream block and 'off' in http block - response_body - response is expected (repeated req 0, req 0)
# @@ -1,2 +1,2 @@
#  resty.core loaded in stream: true
# -resty.core loaded in http: false
# +resty.core loaded in http: true
# '
#   at /usr/local/share/perl/5.18.2/Test/Nginx/Socket.pm line 1589.

Tests fails since resty.core is not loaded in http, but I don't know the reason yet.
Could you give some advice to investigate?
Thanks!

@hnakamur
Copy link
Author

Ah I see.

nginx: [warn] lua_load_resty_core is deprecated (the lua-resty-core library is required since ngx_lua v0.10.16)

So resty.core is always loaded, then existing tests in stream-lua-nginx-module should be updated.

@hnakamur
Copy link
Author

Test passes at https://travis-ci.org/hnakamur/stream-lua-nginx-module/builds/570491636
with t/161-load-resty-core.t deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants