Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix castException with byte[] #965

Open
wants to merge 2 commits into
base: integration
Choose a base branch
from

Conversation

samalloing
Copy link
Collaborator

Hi @carlwilson
In the Viewer there is a CastException in the Byte[] in some WAVE files

This fixes #926

Sam

In the Viewer there is a CastException in the Byte[] in some WAVE files
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.29%. Comparing base (d9cd0c0) to head (bdb3665).
Report is 53 commits behind head on integration.

Additional details and impacted files
@@                Coverage Diff                @@
##             integration     #965      +/-   ##
=================================================
+ Coverage          47.04%   47.29%   +0.25%     
- Complexity          1103     1111       +8     
=================================================
  Files                 57       57              
  Lines               9087     8990      -97     
  Branches            1625     1622       -3     
=================================================
- Hits                4275     4252      -23     
+ Misses              4280     4211      -69     
+ Partials             532      527       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlwilson carlwilson added this to the JHOVE 1.34 milestone Sep 20, 2024
Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the problem and that looks a straightforward fix. Thanks @samalloing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jHove Gui stops without output in WAVE module
2 participants