Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add placeholder info box for index page editing #887

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Nov 18, 2024

Problem

We don't allow adding of blocks to index pages currently, but the add blocks button leads to an empty page, which can be confusing.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Bug Fixes:

  • Prevent the Add block button from appearing for index pages.

@dcshzj dcshzj requested a review from a team as a code owner November 18, 2024 09:36
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 9:40am

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Nov 18, 2024

Datadog Report

Branch report: fix/placeholder-edit-indexpage
Commit report: 8e85e01
Test service: isomer-studio

✅ 0 Failed, 189 Passed, 34 Skipped, 39.93s Total Time
➡️ Test Sessions change in coverage: 1 no change

@adriangohjw adriangohjw merged commit dab16ba into main Nov 18, 2024
27 checks passed
@adriangohjw adriangohjw deleted the fix/placeholder-edit-indexpage branch November 18, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants