upgrade to next15 #860
upgrade to next15 #860
Conversation
adriangohjw
added
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Datadog ReportBranch report: ✅ 0 Failed, 167 Passed, 34 Skipped, 34.92s Total Time |
|
need to put on HOLD because storybook is not compatible with next15 yet storybookjs/storybook#29421 |
adriangohjw
force-pushed
the
dependencies-next15
branch
from
c719ed1
to
c151c70
Compare
| @@ -18,7 +18,7 @@ | |||
| "format:fix": "turbo format --continue -- --write --cache --cache-location node_modules/.cache/.prettiercache --ignore-path ./.prettierignore", | |||
| "lint": "turbo lint --continue -- --cache --cache-location node_modules/.cache/.eslintcache", | |||
| "lint:fix": "turbo lint --continue -- --fix --cache --cache-location node_modules/.cache/.eslintcache", | |||
| "lint:ws": "npx [email protected]", | |||
| "lint:ws": "npx [email protected] -i next", | |||
There was a problem hiding this comment.
can i clarify what -i next does?
There was a problem hiding this comment.
it tells sherif to ignore the different next versions and not raise it as error
this is needed because postinstall runs lint:ws and block npm i from proceeding
| @@ -12,11 +12,13 @@ import { | |||
| RenderEngine, | |||
| } from "@opengovsg/isomer-components" | |||
|
|
|||
| export const dynamic = "force-static" | |||
There was a problem hiding this comment.
do we need this statement across the files? could you summarise what this implies?
There was a problem hiding this comment.
I would think that having the following in the next.config will auto-force all to be static
const nextConfig = {
output: "export",
There was a problem hiding this comment.
@harishv7 yeah i would think so too but somehow not including this will cause an issue during next build
Problem
Hoping to leverage the performance improvement stated in https://nextjs.org/blog/next-15#faster-static-generation-for-the-app-router to speed up SSG which is the remaining main bottleneck of slow build
partially closes https://linear.app/ogp/issue/ISOM-1661/optimise-site-build-times
Solution
Breaking Changes
Improvements:
next buildby 3 minutes (540s -> 360s) when tested onmoh-corpPRODnote:
tooling/templatebecause next 15 is not supported by storybook used in studio at the moment. Thus we have to tell the lint to exclude itTests
New dependencies:
dependency:nextto v15