feat: fix Input prefill style regression, add isPrefilled prop to Datepicker and Select
#754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
changed the title
isPrefilled prop to date and select components
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
karrui
changed the title
isPrefilled prop to date and select componentsisPrefilled prop to Datepicker and Select components
karrui
changed the title
isPrefilled prop to Datepicker and Select componentsisPrefilled prop to Datepicker and Select
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the regression where
isPrefilledstate started to do nothing on theInputcomponent due to downstream ChakraUI changes on their Input component.This PR also adds the
isPrefilledprop to the following components:SingleSelectMultiSelectDatePickerDateRangePickerThe prefilled styling follows the styling of the
Inputcomponent.See storybook for details.