feat: 5335 - owner field icon/info for "categories" #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `add_basic_details_page.dart`: minor refactoring * `nutrition_page_loaded.dart`: minor refactoring * `owner_field_info.dart`: new class `OwnerFieldIcon` * `simple_input_page.dart`: now displays an `OwnerFieldInfo` if there's at least one owner field * `simple_input_page_helpers.dart`: new method `bool isOwnerField` * `simple_input_text_field.dart`: minor refactoring * `simple_input_widget.dart`: now displays an `OwnerFieldIcon` if it's an owner field
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5845 +/- ##
==========================================
- Coverage 9.54% 6.92% -2.63%
==========================================
Files 325 422 +97
Lines 16411 23263 +6852
==========================================
+ Hits 1567 1611 +44
- Misses 14844 21652 +6808 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshots
Fixes bug(s)
Impacted files
add_basic_details_page.dart: minor refactoringnutrition_page_loaded.dart: minor refactoringowner_field_info.dart: new classOwnerFieldIconsimple_input_page.dart: now displays anOwnerFieldInfoif there's at least one owner fieldsimple_input_page_helpers.dart: new methodbool isOwnerFieldsimple_input_text_field.dart: minor refactoringsimple_input_widget.dart: now displays anOwnerFieldIconif it's an owner field