Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Missing birthday cake for new products #5651

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

thedevyash
Copy link

What

added the missing birthday cake svg from the "assets/onboarding/ "

Screenshot

WhatsApp Image 2024-09-30 at 21 32 17_d1b58fc1

  • Fixes:

Closes: "Missing birthday cake for new products" link #5647

@github-actions github-actions bot added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Sep 30, 2024
@thedevyash thedevyash changed the title Missing birthday cake for new products chore: Missing birthday cake for new products Sep 30, 2024
@g123k
Copy link
Collaborator

g123k commented Oct 1, 2024

The illustration has an issue because the candles are white on white.

@thedevyash
Copy link
Author

The illustration has an issue because the candles are white on white.

yes thats an issue with the svg itself...do you have an alternate svg or do you want me to tweak its colors a bit?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.87%. Comparing base (4d9c7fc) to head (33516d2).
Report is 340 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5651      +/-   ##
==========================================
- Coverage     9.54%   6.87%   -2.68%     
==========================================
  Files          325     402      +77     
  Lines        16411   21316    +4905     
==========================================
- Hits          1567    1466     -101     
- Misses       14844   19850    +5006     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thedevyash
Copy link
Author

The illustration has an issue because the candles are white on white.

birthday-cake

this works?

@M123-dev
Copy link
Member

M123-dev commented Oct 7, 2024

I think the dark background on a white dialog is even more distracting.

I'm no designer, maybe someone on the openfoodfacts Slack #design is interested in providing a altered version. Maybe one for light and one for dark background

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

Missing birthday cake for new products
4 participants