fix!: fix should_download_file function #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the should_download_file function was buggy, as we didn't always force the download of the file when `force_download` was True and `download_newer` was True as well.
raphael0202
force-pushed
the
fix-should-download-function
branch
from
fdc8569
to
351fa7d
Compare
|
raphael0202
added a commit
to openfoodfacts/openfoodfacts-exports
that referenced
this pull request
Nov 18, 2024
Version 2.0.0 fixes the dataset caching issue. See: openfoodfacts/openfoodfacts-python#284
raphael0202
added a commit
to openfoodfacts/openfoodfacts-exports
that referenced
this pull request
Nov 18, 2024
Version 2.0.0 fixes the dataset caching issue. See: openfoodfacts/openfoodfacts-python#284
raphael0202
added a commit
to openfoodfacts/openfoodfacts-exports
that referenced
this pull request
Nov 18, 2024
Version 2.0.0 fixes the dataset caching issue. See: openfoodfacts/openfoodfacts-python#284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the should_download_file function was buggy, as we didn't always force the download of the file when
force_downloadwas True anddownload_newerwas True as well.