OPENEUROPA-2155: Add dev option to settings setup command #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
previously approved these changes
Sep 16, 2019
added 9 commits
January 27, 2020 11:02
ademarco
force-pushed
the
OPENEUROPA-2155
branch
from
7cb87f5
to
b300573
Compare
…es MULTISITE-22694 too.
ademarco
previously approved these changes
Jan 27, 2020
sergepavle
reviewed
Jan 28, 2020
| - file: "build/sites/default/settings.local.php" | ||
| contains: "// Initial config." | ||
|
|
||
| - configuration: |
There was a problem hiding this comment.
Looks like duplication with line 47.
| @@ -0,0 +1,92 @@ | |||
| - configuration: | |||
There was a problem hiding this comment.
May be it is out from scope but could we also test correct working with multisiting?
There was a problem hiding this comment.
Fair point, evil, but fair. I'll do it.
There was a problem hiding this comment.
Real multisite integration would require extra work to allow for building multiple config folders.
I have some thoughts on how this can best be accomplished. Would require the runner.yml to define site.keys under which you can define the regular properties.
sergepavle
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-2155
Description
Add dev option to settings setup command, it will create and use settings.local.phpp .
Change log