ISSUE-293: Add template for Content row paragraph type Columns layout variant. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msnassar
previously approved these changes
Aug 12, 2019
ademarco
approved these changes
Aug 12, 2019
ademarco
requested changes
Aug 12, 2019
sergepavle
reviewed
Dec 20, 2019
| if (is_numeric($layout_settings)) { | ||
| // Set column count and layout for equal width columns. | ||
| $column_count = (int) $layout_settings; | ||
| $layout = array_fill(0, $column_count, $grid_column_count / $column_count); |
There was a problem hiding this comment.
By validation before we should avoid chance to get float number
sergepavle
reviewed
Dec 20, 2019
| } | ||
| else { | ||
| // Set column count and layout for variable width columns. | ||
| $layout = explode('-', $layout_settings) ?? [$grid_column_count]; |
There was a problem hiding this comment.
Require validation that we have number of columns in sum equels 12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE-293
Description
openeuropa/oe_paragraphs#65 introduces a new variant (Columns Layout) for the 'content row' paragraph type. This issue is created to contribute the theming logic that will be responsible to render multi-column layouts for this new variant.
Change log
Template file for the new variant.
oe_theme.theme (added preprocess function for the new variant)
composer.json (added patch for oe_paragraphs new variant temporarily)