OEL-757: Add new fields alignment and title_tag to listing. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escuriola
reviewed
Nov 19, 2021
| @@ -82,6 +82,7 @@ listing_default_1_col: | |||
| 'p.card-text.mb-3': 4 | |||
| 'span.me-4': 4 | |||
| 'span.mb-2': 8 | |||
| 'h5.card-title': 4 | |||
There was a problem hiding this comment.
Add link attributes testing:
Suggested change
| 'h5.card-title': 4 | |
| 'h5.card-title': 4 | |
| 'a.d-inline-block': 1 |
| 'div.row': 7 | ||
| 'div.listing-item': 6 | ||
| 'img.rounded-1': 5 | ||
| 'p.card-text.mb-3': 6 | ||
| 'span.me-4': 6 | ||
| 'span.mb-2': 12 | ||
| 'h5.card-title': 6 |
There was a problem hiding this comment.
Add link attributes testing:
Suggested change
| 'h5.card-title': 6 | |
| 'h5.card-title': 6 | |
| 'a.d-inline-block': 1 |
| 'div.row': 7 | ||
| 'div.listing-item': 6 | ||
| 'img.rounded-1': 5 | ||
| 'p.card-text.mb-3': 6 | ||
| 'span.me-4': 6 | ||
| 'span.mb-2': 12 | ||
| 'h5.card-title': 6 | ||
| 'h4.fw-bold.mb-4': 1 |
There was a problem hiding this comment.
Add link attributes testing:
Suggested change
| 'h4.fw-bold.mb-4': 1 | |
| 'h5.card-title': 4 | |
| 'a.d-inline-block': 1 |
There was a problem hiding this comment.
Assert also .mw-listing-img' and 'mw-date'
when image or date is displayed, for instance:
'.mw-listing-img': 5
on "listing_default_3_col_tag
There was a problem hiding this comment.
Yes, for this PR it will be done for image and later on, on the corresponding PR, I'll add it for date.
abel-santos-corral
force-pushed
the
OEL-750-all
branch
from
f4b6530
to
6a03c2a
Compare
… BCL update version 13.
abel-santos-corral
force-pushed
the
OEL-757
branch
from
2dd7859
to
414997c
Compare
abel-santos-corral
force-pushed
the
OEL-750-all
branch
2 times, most recently
from
db59502
to
078c664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s):