feat: transition apache to use php-fpm/fcgi in dockers #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradymiller
commented
Mar 8, 2024
| @@ -3,20 +3,27 @@ FROM alpine:3.19 | |||
| #Install dependencies and fix issue in apache | |||
| RUN apk --no-cache upgrade | |||
| RUN apk add --no-cache \ | |||
| apache2 apache2-ssl apache2-utils apache2-proxy git php83 php83-tokenizer php83-ctype php83-session php83-apache2 \ | |||
| apache2 apache2-ssl apache2-utils apache2-proxy git php83 php83-fpm php83-tokenizer php83-ctype php83-session \ | |||
There was a problem hiding this comment.
note we are actually removing the php83-apache2 module :)
bradymiller
commented
Mar 8, 2024
| RUN sed -i "s/^user = [^ ]*/user = apache/" /etc/php83/php-fpm.d/www.conf | ||
| RUN sed -i "s/^group = [^ ]*/group = apache/" /etc/php83/php-fpm.d/www.conf | ||
| RUN sed -i "/^LoadModule mpm_prefork_module modules\/mod_mpm_prefork.so/ s/^/#/" /etc/apache2/httpd.conf | ||
| RUN sed -i "/LoadModule mpm_event_module modules\/mod_mpm_event.so/ s/# *//" /etc/apache2/httpd.conf |
There was a problem hiding this comment.
above 2 lines will basically comment out the apache prefork MPM and then uncomment the apache event MPM
bradymiller
commented
Mar 8, 2024
| perl mysql-client tar curl imagemagick nodejs npm \ | ||
| certbot openssl openssl-dev dcron \ | ||
| rsync shadow ncurses \ | ||
| && sed -i 's/^Listen 80$/Listen 0.0.0.0:80/' /etc/apache2/httpd.conf | ||
| # Needed to ensure permissions work across shared volumes with openemr, nginx, and php-fpm dockers | ||
| RUN usermod -u 1000 apache | ||
|
|
||
| #BELOW LINE NEEDED TO SUPPORT PHP8 ON ALPINE 3.13+; SHOULD BE ABLE TO REMOVE THIS IN FUTURE ALPINE VERSIONS | ||
| #STEPS TO ENSURE php and php-fpm/fcgi both work, which configure proper user/group for php-fpm and set the alpine Event MPM |
There was a problem hiding this comment.
will need to fix comment above and change alpine to apache
stephenwaite
reviewed
Mar 8, 2024
| @@ -451,6 +451,8 @@ echo " > https://opencollective.com/openemr/donate" | |||
| echo "" | |||
|
|
|||
| if [ "$OPERATOR" == "yes" ]; then | |||
| echo "Starting php-fpm!" | |||
| /usr/sbin/php-fpm | |||
bradymiller
force-pushed
the
apache-php-fpm-fcgi_1
branch
from
2248128
to
8718809
Compare
|
Noted some performance issues with this (appears it needs to be optimized dependent on server resources; out of box settings appear to not allow enough servers (a bunch of these settings) to optimally serve OpenEMR), so plan to make this turned on via a docker setting along with settings to optimize (nice excuse to learn more about php-fpm :) ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #384
(continued from #383)
transition apache to use php-fpm/fcgi in dockers
To ensure that the apache php-fpm/fcgi is actually working: in OpenEMR, go to Admin->System->Diagnostic (
SAPIsetting should befpm-fcgi)