-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): update jest-dom #2868
chore(deps-dev): update jest-dom #2868
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -1,6 +1,6 @@ | |||
import React from 'react'; | |||
import { render, screen } from '@testing-library/react'; | |||
import '@testing-library/jest-dom/extend-expect'; | |||
import '@testing-library/jest-dom'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this change I encountered
Summary of all failing tests
FAIL src/SelectableBox/tests/SelectableBoxSet.test.jsx
● Test suite failed to run
Cannot find module '@testing-library/jest-dom/extend-expect' from 'src/SelectableBox/tests/SelectableBoxSet.test.jsx'
1 | import React from 'react';
2 | import { render, screen } from '@testing-library/react';
> 3 | import '@testing-library/jest-dom/extend-expect';
| ^
4 | import userEvent from '@testing-library/user-event';
5 | import SelectableBox from '..';
6 |
at Resolver._throwModNotFoundError (node_modules/jest-resolve/build/resolver.js:491:11)
at Object.require (src/SelectableBox/tests/SelectableBoxSet.test.jsx:3:1)
when running tests locally.
I found this suggestion and it resolved the issue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2868 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 235 235
Lines 4240 4240
Branches 1029 1029
=======================================
Hits 3936 3936
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
559ff66
to
a75e81b
Compare
🎉 This PR is included in version 21.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
I looked into #2845 and saw that
@adobe/css-tools
is in our dependency tree by means ofjest-dom
. As ofjest-dom
6.1.4
the dependency has been updated to address the mentioned vulnerability.I figured this was a good excuse to update our
jest-dom
dependency.Merge Checklist
Post-merge Checklist