Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: snapshot listing query type #79

Merged
merged 3 commits into from
Aug 21, 2023
Merged

refactor: snapshot listing query type #79

merged 3 commits into from
Aug 21, 2023

Conversation

Abhinandan-Purkait
Copy link
Contributor

@Abhinandan-Purkait Abhinandan-Purkait commented Aug 21, 2023

TypeDef:

 message Query {
        optional bool invalid = 1; // Filter based on invalid if some.
        optional bool discarded = 2; // Filter based on discarded if some.
    }

Worflow:

  • If Query.invalid or Query.discarded is Some(val), compare the SnapshotInfo with the val followed by && operation.
  • If Query.invalid or Query.discarded is None, don't include the field in compare of SnapshotInfo.

Signed-off-by: Abhinandan Purkait <[email protected]>
@tiagolobocastro tiagolobocastro merged commit 396a075 into develop Aug 21, 2023
3 checks passed
@tiagolobocastro tiagolobocastro deleted the list-snap branch August 21, 2023 12:55
@tiagolobocastro
Copy link
Contributor

Ah sorry I shouldn't have merged this yet as io-engine PR is not yet ready..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants