add @dch to CODEOWNERS #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaste
approved these changes
Apr 4, 2024
samuelkarp
approved these changes
Apr 4, 2024
dfr
approved these changes
Apr 5, 2024
|
@dch Can you update this and add a Signed-off-by line to the commit message, indicating agreement to https://developercertificate.org/? That's the CI check that's failing now. |
Signed-off-by: Dave Cottlehuber <[email protected]>
|
GitHub reports: |
|
@samuelkarp I think we need you to merge this still |
|
@jorydotcom Can you add write access for @dch to this repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amye you sent me the original email but I wasn't able to respond in time; per original WG proposal I'd like to be an owner.
I believe for CODEOWNERS to work correctly, both @gtewallace & @dch (myself) need to be added to repo maintainer group.