Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore error when xattr data is not available #457

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Commits on Oct 25, 2023

  1. fix(compress): allow passing in compressor options

    Goals of this PR:
    1. Allow passing in options to individual compressor
    2. Do not change default behavior
    
    Signed-off-by: Ramkumar Chinchani <[email protected]>
    rchincha committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    7927617 View commit details
    Browse the repository at this point in the history
  2. fix(compress): set default copy buffer to 1 MiB

    Signed-off-by: Ramkumar Chinchani <[email protected]>
    rchincha committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c7bb24d View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. avoid failing when lgetxattr has no data to give

    Signed-off-by: Serge Hallyn <[email protected]>
    hallyn committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    3c661c1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request opencontainers#3 from hallyn/2024-01-22/backport-f…

    …ix-empty-lgetxattr
    
    2024 01 22/backport fix empty lgetxattr
    rchincha authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    cb3aca5 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. generateinsertlayer: close the tarwriter

    generatelayer closes the tarwriter, but generateinsertlayer forgets to.
    
    Closing the tarwriter writes the required footer of 1k of zeros.
    
    This results in tar files that are complete but invalid, and different
    reading tools will behave differently:
    
    - bsdtar doesn't complain and exits 0
    - gnu tar (and security scanning tools that use it) will exit 2 with an
    unexpected EOF message
    - python's tarfile library will raise an Unexpected EOF error
    - golang's archive/tar library can raise an unexpected EOF error, but
      for some files created by generateinsertlayer, it just raises a
      plain EOF error, which means golang based tools generally ignore this
      and work fine, this includes umoci.
    
    Signed-off-by: Michael McCracken <[email protected]>
    (cherry picked from commit ad29ed3)
    mikemccracken committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1661f84 View commit details
    Browse the repository at this point in the history
  2. generate: do not warn about err on success

    This warning is a little confusing when err is nil,
    and doesn't add any info in that case. Let's clean that up.
    
    Signed-off-by: Michael McCracken <[email protected]>
    (cherry picked from commit 653952b)
    mikemccracken committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    7a7284e View commit details
    Browse the repository at this point in the history
  3. test: check blobs with gnutar, add sm file insert

    add a check to image-verify to ensure that all generated tar blobs are
    valid and do not cause gnu tar to exit nonzero
    
    add an insert test that adds a very small file to trigger unexpected EOF
    in the case where GenerateInsertLayer forgets to close the TarWriter.
    
    Signed-off-by: Michael McCracken <[email protected]>
    (cherry picked from commit 7bb2940)
    mikemccracken committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    2366a72 View commit details
    Browse the repository at this point in the history
  4. Merge pull request opencontainers#4 from mikemccracken/2024.02.22/sta…

    …ckerfork-main/close-tarwriter
    
    2024.02.22/stackerfork main/close tarwriter
    hallyn authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    bef7765 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge pull request opencontainers#5 from project-stacker/main

    add tarwriter fixes from upstream
    hallyn authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    555a0af View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. fix: handle overlay xattr opaque bit

    Current behavior determines if a path is a whiteout if a overlay char
    dev is present.
    
    Additionally, also check the extended attrs.
    
    Signed-off-by: Ramkumar Chinchani <[email protected]>
    rchincha committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5b03842 View commit details
    Browse the repository at this point in the history
  2. Merge pull request opencontainers#6 from rchincha/stacker

    fix: handle overlay xattr opaque bit
    rchincha authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    26d688b View commit details
    Browse the repository at this point in the history
  3. fix: handle unix.EACCES error also

    CI failures indicate that this could be another error code that needs
    to be handled.
    
    Signed-off-by: Ramkumar Chinchani <[email protected]>
    rchincha committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4d17e64 View commit details
    Browse the repository at this point in the history