Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: add checkPlatform #469

Closed
wants to merge 1 commit into from
Closed

schema: add checkPlatform #469

wants to merge 1 commit into from

Conversation

zhouhao3
Copy link

Fixes opencontainers/image-tools#39
Signed-off-by: zhouhao [email protected]

@stevvooe
Copy link
Contributor

stevvooe commented Nov 21, 2016

LGTM

Approved with PullApprove

@wking
Copy link
Contributor

wking commented Nov 22, 2016 via email

@zhouhao3
Copy link
Author

@philips @vbatts @jonboulle @stevvooe PTAL

@jonboulle
Copy link
Contributor

These are SHOULDs, not MUSTs. Why should we validate them?
https://github.com/opencontainers/image-spec/blame/master/config.md#L63

@vbatts
Copy link
Member

vbatts commented Nov 30, 2016

i'm okay with them being checked, but not to FAIL a validation.

@wking
Copy link
Contributor

wking commented Dec 1, 2016 via email

@zhouhao3
Copy link
Author

zhouhao3 commented Dec 2, 2016

These are SHOULDs, not MUSTs. Why should we validate them?

Because these two are required attributes, and as the specification says: The name of the operating system which the image is built to run on. If it is the verification of the system, only by JSON to restrict the type is not rigorous, it should be the value of its specific judgment.

@zhouhao3
Copy link
Author

Due to my mistakes, resulting in this PR can not be updated, I will close this, and then open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants