-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gRIBI support for OC AFT model 2.7.0 #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a first pass review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I need to refresh this with minor updates since openconfig/public#1153 was merged. I'll do this today |
@robshakir This is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part way through reviewing -- aeroplane WiFi and GitHub are not super-compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes here -- generally, LGTM. Few small nits :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deviated out vxlan
Revised update-schema.sh
Removed aft network-instance yang dep
Ready for review
scripts/update-schema.sh
Outdated
@@ -38,7 +39,8 @@ if [ -z $SRCDIR ]; then | |||
SRC_DIR=`runreadlink -m ${THIS_DIR}/..` | |||
fi | |||
|
|||
proto_generator \ | |||
echo ${SRC_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove echo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the echo
then LGTM. Thanks.
done! |
Brings gRIBI up to date from OpenConfig AFT model v2.1.0 to v2.7.0
Highlighted updates which impact gRIBI
gre
container under next-hops aft entry state. Addsrc-ip
,dst-ip
andttl
undergre
aft entry state for telemetry. public#1038 v2.4.0Other AFT model revisions did not impact gRIBI as they are related to leaves or attributes not directly related or accessible via the gRIBI RPCs.